Apache9 commented on a change in pull request #1818: URL: https://github.com/apache/hbase/pull/1818#discussion_r433135098
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ImmutableScan.java ########## @@ -0,0 +1,477 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hbase.client; + +import java.io.IOException; +import java.util.Collections; +import java.util.Map; +import java.util.NavigableSet; +import org.apache.hadoop.hbase.filter.Filter; +import org.apache.hadoop.hbase.io.TimeRange; +import org.apache.hadoop.hbase.security.access.Permission; +import org.apache.hadoop.hbase.security.visibility.Authorizations; +import org.apache.yetus.audience.InterfaceAudience; + +/** + * Immutable version of Scan + */ +@InterfaceAudience.Public Review comment: My opinion is to only expose Scan to users, just like Collections.unmodifiableCollection will still return a Collection. For now, the only usecase is in CustomizedScanInfoBuilder, I prefer we do not expose too much, unless in the future we find other usages. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
