[ https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wellington Chevreuil updated HBASE-21406: ----------------------------------------- Resolution: Fixed Status: Resolved (was: Patch Available) Had pushed to master, branch-2 and branch-2.3 branches. > "status 'replication'" should not show SINK if the cluster does not act as > sink > ------------------------------------------------------------------------------- > > Key: HBASE-21406 > URL: https://issues.apache.org/jira/browse/HBASE-21406 > Project: HBase > Issue Type: Improvement > Affects Versions: 3.0.0-alpha-1, 2.3.0, 2.4.0, 2.2.5 > Reporter: Daisuke Kobayashi > Assignee: Wellington Chevreuil > Priority: Minor > Fix For: 3.0.0-alpha-1, 2.3.0, 2.4.0 > > Attachments: HBASE-21406-branch-1.001.patch, > HBASE-21406-master.001.patch, HBASE-21406-master.002.patch, Screen Shot > 2018-10-31 at 18.12.54.png > > > When replicating in 1 way, from source to target, {{status 'replication'}} on > source always dumps SINK with meaningless metrics. It only makes sense when > running the command on target cluster. > {{status 'replication'}} on source, for example. {{AgeOfLastAppliedOp}} is > always zero and {{TimeStampsOfLastAppliedOp}} does not get updated from the > time the RS started since it's not acting as sink. > {noformat} > source-1.com > SOURCE: PeerID=1, AgeOfLastShippedOp=0, SizeOfLogQueue=0, > TimeStampsOfLastShippedOp=Mon Oct 29 23:44:14 PDT 2018, Replication Lag=0 > SINK : AgeOfLastAppliedOp=0, TimeStampsOfLastAppliedOp=Thu Oct 25 > 23:56:53 PDT 2018 > {noformat} > {{status 'replication'}} on target works as expected. SOURCE is empty as it's > not acting as source: > {noformat} > target-1.com > SOURCE: > SINK : AgeOfLastAppliedOp=70, TimeStampsOfLastAppliedOp=Mon Oct 29 > 23:44:08 PDT 2018 > {noformat} > This is because {{getReplicationLoadSink}}, called in {{admin.rb}}, always > returns a value (not null). > 1.X > https://github.com/apache/hbase/blob/rel/1.4.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L194-L204 > 2.X > https://github.com/apache/hbase/blob/rel/2.0.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L392-L399 -- This message was sent by Atlassian Jira (v8.3.4#803005)