Apache9 commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-638527858
> Thanks for suggestion @Apache9, but I don't think that's going to work for the case of state being `SERVER_CRASH_FINISH`. With such code change, `executeFromState` will end up calling `updateProgress(true)` at the beginning of the function marking the task as done. Whereas it should be actually marking the task as done when switch `case SERVER_CRASH_FINISH` is called. > > Also, could you please explain a rationale about adding a task during procedure deserialization? If procedure has finished during run of previous, what is the value in displaying it in tasks as "completed" when a new master comes after replaying the logs? In other words, should a simple fact of deserialization have such a side effect on tasks or should actual procedure execution drive the tasks updates instead? I think unless you call update progress, otherwise the procedure will not show up in the TaskMonitor? The updateProgress call in deserialization is something like an initialization. If there are so many SCPs, maybe it is possible that one of the SCPs can not be scheduled for a long time, then if you do not all updateProgress in deserialization, you can not see its current status for a long tim, until it gets scheduled. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org