[ 
https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125835#comment-17125835
 ] 

Duo Zhang commented on HBASE-23313:
-----------------------------------

OK, I checked the code in HBCK2.

https://github.com/apache/hbase-operator-tools/blob/master/hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java#L166

The method introduced here has not been used yet.

For me, I do not think it is a good idea to use a full RegionState as 
parameter. On the HBCK2 command line, we only pass a region state and an 
encoded region name, so here, I suggest we introduce a new datastructure, which 
only has a encoded name and a state, and use it as the parameter.

If no big concerns, I will open a sub task to fix the problem here, and then 
update the PR for HBASE-24500, as for HBASE-24500, it should also be included 
in branch-2.2.

Thanks.

> [hbck2] setRegionState should update Master in-memory state too
> ---------------------------------------------------------------
>
>                 Key: HBASE-23313
>                 URL: https://issues.apache.org/jira/browse/HBASE-23313
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck2
>    Affects Versions: 2.1.7, 2.2.2
>            Reporter: Michael Stack
>            Assignee: Wellington Chevreuil
>            Priority: Major
>             Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> setRegionState changes the hbase:meta table info:state column. It does not 
> alter the Master's in-memory state. This means you have to kill Master and 
> have another assume Active Master role of a state-change to be noticed. 
> Better if the setRegionState just went via Master and updated Master and 
> hbase:meta.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to