sguggilam commented on a change in pull request #1828:
URL: https://github.com/apache/hbase/pull/1828#discussion_r436014652
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java
##########
@@ -233,13 +233,19 @@ public void run() {
private int numberOfAttemptsSoFar = 0;
private long maxWaitTime = -1;
+ private final long rsRpcRetryInterval;
Review comment:
@Apache9 This is useful for the cases where there is an injected
environment edge and when the first RS RPC request fails causing it to go to
the retry block.
In the absence of this , the default timeout would be set to 100 ms and the
DelayedUtil class is meant to execute the retry after 100 ms. However as per
the getRemainingTime() logic here
(https://github.com/apache/hbase/blob/5b01e613fbbb92e243e99a1d199b4ffbb21ed2d9/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/util/DelayedUtil.java#L94),
the equation would be evaluated to
EnvironmentEdgeManager.currentTime() >= EnvironmentEdgeManager.currentTime()
+ 100 which would never get evaluated to true in case of injected edge and
retry never happens. Hence this config helps you to override it to 0 in cases
we want to test with a manual injected environment edge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
