Apache9 commented on pull request #1858:
URL: https://github.com/apache/hbase/pull/1858#issuecomment-640059821


   @busbey it is really not easy to implement the UT. You have to use the 
RoundRobin connection pool and set the pool size to greater than 1. And I tried 
several ways, it is really not easy to control which connection is returned, as 
the retries are in a separated timer thread, and also the first attemp is in 
the client thread, not in the event loop thread...
   
   Since the patch here will remove all locks, we can make sure that the dead 
lock problem is gone, so I think it is fine to not introduce a UT?
   
   I will have a simple PE run to see if there are performance issues.
   
   Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to