pustota2009 commented on a change in pull request #1257:
URL: https://github.com/apache/hbase/pull/1257#discussion_r436525391
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
##########
@@ -338,6 +373,17 @@ public LruBlockCache(long maxSize, long blockSize, boolean
evictionThread,
} else {
this.evictionThread = null;
}
+
+ // check the bounds
+ this.heavyEvictionCountLimit = heavyEvictionCountLimit < 0 ? 0 :
heavyEvictionCountLimit;
+ this.heavyEvictionMbSizeLimit = heavyEvictionMbSizeLimit < 1 ? 1 :
heavyEvictionMbSizeLimit;
+ this.cacheDataBlockPercent = 100;
Review comment:
It is fine here, because 100 is initial value. We will adjust it from
this level.
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
##########
@@ -655,23 +716,29 @@ long getOverhead() {
/**
* Eviction method.
*/
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
