[ https://issues.apache.org/jira/browse/HBASE-23202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129326#comment-17129326 ]
Hudson commented on HBASE-23202: -------------------------------- Results for branch master [build #1752 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1752/]: (/) *{color:green}+1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1752/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1752/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/master/1752/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > ExportSnapshot (import) will fail if copying files to root directory takes > longer than cleaner TTL > -------------------------------------------------------------------------------------------------- > > Key: HBASE-23202 > URL: https://issues.apache.org/jira/browse/HBASE-23202 > Project: HBase > Issue Type: Bug > Components: snapshots > Affects Versions: 3.0.0-alpha-1, 1.5.0, 2.2.1, 1.4.11, 2.1.7 > Reporter: Zach York > Assignee: Guangxu Cheng > Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > > HBASE-17330 removed the checking of the snapshot .tmp directory when > determining which files are candidates for deletes. It appears that in the > latest branches, this isn't an issue for taking a snapshot as it checks > whether a snapshot is in progress via the SnapshotManager. > However, when using the ExportSnapshot tool to import a snapshot into a > cluster, it will first copy the snapshot manifest into > /.snapshot/.tmp/<snapshot> [1], copies the files, and then renames the > snapshot manifest to the final snapshot directory. If the copyFiles job takes > longer than the cleaner TTL, the ExportSnapshot job will fail because HFiles > will get deleted before the snapshot is committed to the final directory. > The ExportSnapshot tool already has a functionality to skipTmp and write the > manifest directly to the final location. However, this has unintended > consequences such as the snapshot appearing to the user before it is usable. > So it looks like we will have to bring back the tmp directory check to avoid > this situation. > [1] > https://github.com/apache/hbase/blob/master/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java#L1029 -- This message was sent by Atlassian Jira (v8.3.4#803005)