busbey commented on a change in pull request #1620:
URL: https://github.com/apache/hbase/pull/1620#discussion_r439168692
##########
File path: dev-support/create-release/do-release-docker.sh
##########
@@ -162,15 +219,15 @@ GIT_NAME=$GIT_NAME
GIT_EMAIL=$GIT_EMAIL
GPG_KEY=$GPG_KEY
ASF_PASSWORD=$ASF_PASSWORD
-GPG_PASSPHRASE=$GPG_PASSPHRASE
RELEASE_STEP=$RELEASE_STEP
API_DIFF_TAG=$API_DIFF_TAG
+HOST_OS=$HOST_OS
EOF
-JAVA_VOL=()
+JAVA_MOUNT=()
if [ -n "$JAVA" ]; then
echo "JAVA_HOME=/opt/hbase-java" >> "$ENVFILE"
- JAVA_VOL=(--volume "$JAVA:/opt/hbase-java")
+ JAVA_MOUNT=(--mount "type=bind,src=${JAVA},dst=/opt/hbase-java,readonly")
Review comment:
we do install it in the docker image, that's the default. I have only
done my java builds via the docker image java. I just updated this to use the
preferred cli options instead of the legacy ones. I presume it was important
for someone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
