[ 
https://issues.apache.org/jira/browse/HBASE-24546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

wenfeiyi666 updated HBASE-24546:
--------------------------------
    Description: 
since regions dir was not remove in the previous execution created,  need to be 
remove when retrying, resulting in exception, unlimited retry
{code:java}
procedure.CloneSnapshotProcedure: Retriable error trying to clone 
snapshot=snapshot_test to table=test:backup state=CLONE_SNAPSHOT_WRITE_FS_LAYOUT
org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: clone snapshot={ 
ss=snapshot_test table=test:backup type=FLUSH } failed because A clone should 
not have regions to remove
        at 
org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure$1.createHdfsRegions(CloneSnapshotProcedure.java:434)
        at 
org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.createFsLayout(CloneSnapshotProcedure.java:465)
        at 
org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.createFilesystemLayout(CloneSnapshotProcedure.java:392)
        at 
org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.executeFromState(CloneSnapshotProcedure.java:142)
        at 
org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.executeFromState(CloneSnapshotProcedure.java:67)
        at 
org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:194)
        at 
org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:962)
        at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1662)
        at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1409)
        at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:78)
        at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1979)
Caused by: java.lang.IllegalArgumentException: A clone should not have regions 
to remove
        at 
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
        at 
org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure$1.createHdfsRegions(CloneSnapshotProcedure.java:418)
        ... 10 more
{code}

and the cloned regions are unchanged, resulting in new created regions being 
removed when retrying

  was:
since regions was not remove in the previous execution created,  need to be 
remove when retrying, resulting in exception, unlimited retry
{code:java}
procedure.CloneSnapshotProcedure: Retriable error trying to clone 
snapshot=snapshot_test to table=test:backup state=CLONE_SNAPSHOT_WRITE_FS_LAYOUT
org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: clone snapshot={ 
ss=snapshot_test table=test:backup type=FLUSH } failed because A clone should 
not have regions to remove
        at 
org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure$1.createHdfsRegions(CloneSnapshotProcedure.java:434)
        at 
org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.createFsLayout(CloneSnapshotProcedure.java:465)
        at 
org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.createFilesystemLayout(CloneSnapshotProcedure.java:392)
        at 
org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.executeFromState(CloneSnapshotProcedure.java:142)
        at 
org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.executeFromState(CloneSnapshotProcedure.java:67)
        at 
org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:194)
        at 
org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:962)
        at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1662)
        at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1409)
        at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:78)
        at 
org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1979)
Caused by: java.lang.IllegalArgumentException: A clone should not have regions 
to remove
        at 
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
        at 
org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure$1.createHdfsRegions(CloneSnapshotProcedure.java:418)
        ... 10 more
{code}

and the cloned regions are unchanged, resulting in new created regions being 
removed when retrying


> CloneSnapshotProcedure unlimited retry
> --------------------------------------
>
>                 Key: HBASE-24546
>                 URL: https://issues.apache.org/jira/browse/HBASE-24546
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 2.3.0, master, 2.2.5
>            Reporter: wenfeiyi666
>            Assignee: wenfeiyi666
>            Priority: Major
>             Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.6
>
>
> since regions dir was not remove in the previous execution created,  need to 
> be remove when retrying, resulting in exception, unlimited retry
> {code:java}
> procedure.CloneSnapshotProcedure: Retriable error trying to clone 
> snapshot=snapshot_test to table=test:backup 
> state=CLONE_SNAPSHOT_WRITE_FS_LAYOUT
> org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: clone snapshot={ 
> ss=snapshot_test table=test:backup type=FLUSH } failed because A clone should 
> not have regions to remove
>         at 
> org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure$1.createHdfsRegions(CloneSnapshotProcedure.java:434)
>         at 
> org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.createFsLayout(CloneSnapshotProcedure.java:465)
>         at 
> org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.createFilesystemLayout(CloneSnapshotProcedure.java:392)
>         at 
> org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.executeFromState(CloneSnapshotProcedure.java:142)
>         at 
> org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.executeFromState(CloneSnapshotProcedure.java:67)
>         at 
> org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:194)
>         at 
> org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:962)
>         at 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1662)
>         at 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1409)
>         at 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:78)
>         at 
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1979)
> Caused by: java.lang.IllegalArgumentException: A clone should not have 
> regions to remove
>         at 
> org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
>         at 
> org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure$1.createHdfsRegions(CloneSnapshotProcedure.java:418)
>         ... 10 more
> {code}
> and the cloned regions are unchanged, resulting in new created regions being 
> removed when retrying



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to