ramkrish86 commented on a change in pull request #1552:
URL: https://github.com/apache/hbase/pull/1552#discussion_r441335976
##########
File path:
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
##########
@@ -302,6 +308,24 @@ void snapshot(MetricsRecordBuilder mrb, boolean ignored) {
regionNamePrefix + MetricsRegionSource.MAX_FLUSH_QUEUE_SIZE,
MetricsRegionSource.MAX_FLUSH_QUEUE_DESC),
this.regionWrapper.getMaxFlushQueueSize());
+ addCounter(mrb, this.regionWrapper.getMemstoreOnlyRowReadsCount(),
+ MetricsRegionSource.ROW_READS_ONLY_ON_MEMSTORE,
+ MetricsRegionSource.ROW_READS_ONLY_ON_MEMSTORE_DESC);
+ addCounter(mrb, this.regionWrapper.getMixedRowReadsCount(),
+ MetricsRegionSource.MIXED_ROW_READS,
+ MetricsRegionSource.MIXED_ROW_READS_ON_STORE_DESC);
Review comment:
> We don't have it already with the general read count?
This is a read count across all stores. But now what we get additionally is
per store how much is the read count that hit both memstore and files - also
one more where we say how many rows per store came out of memstore only.
Ideally the sum of these values per store should be equal to the total read
count per region.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
