saintstack commented on a change in pull request #1912:
URL: https://github.com/apache/hbase/pull/1912#discussion_r441782616
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionRemoteProcedureBase.java
##########
@@ -365,4 +363,17 @@ protected void
deserializeStateData(ProcedureStateSerializer serializer) throws
protected void afterReplay(MasterProcedureEnv env) {
getParent(env).attachRemoteProc(this);
}
+
+ @Override public String getProcName() {
Review comment:
proc name should be short. stringclassdetails should be all parameters.
Sometimes the name and the stringclassdetails are the same if there is nothing
much to show for a procedure.
In this case, I think target server is a fundamental attribute of
RegionRemoteProcedure so thought it should be in the proc name. Could move it
to the string details.....Let me do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
