BukrosSzabolcs commented on a change in pull request #1903:
URL: https://github.com/apache/hbase/pull/1903#discussion_r442153315



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1166,7 +1166,11 @@ private void 
finishActiveMasterInitialization(MonitoredTask status) throws IOExc
     assignmentManager.checkIfShouldMoveSystemRegionAsync();
     status.setStatus("Assign meta replicas");
     MasterMetaBootstrap metaBootstrap = createMetaBootstrap();
-    metaBootstrap.assignMetaReplicas();
+    try {
+      metaBootstrap.assignMetaReplicas();
+    } catch (HBaseIOException e){

Review comment:
       Good question. The idea was, that as far as I can tell 
`InterruptedException` is never actually thrown and KeeperException represent a 
serious issue outside the scope of meta replication, that we should not hide. 
So I skipped those. Do you think some of them should be included?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to