[
https://issues.apache.org/jira/browse/HBASE-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141589#comment-17141589
]
Andrew Kyle Purtell edited comment on HBASE-17448 at 6/21/20, 11:11 PM:
------------------------------------------------------------------------
This was reverted because our metrics implementation ultimately instantiates
Hadoop version specific code via ServiceLoader, and while that might be fine
for the server side, it’s not for clients, where it can cause havoc. Issue is
the ZK code to be instrumented is in client packages.
I stopped following this after the revert. I don’t think any new attempts have
been made since but may have missed it.
was (Author: apurtell):
This was reverted because our metrics implementation ultimately instantiates
Hadoop version specific code via ServiceLoader, and while that might be fine
for the server side, it’s not for clients, where it can cause havoc. Issue is
the ZK code to be instrumented is in client packages.
> Export metrics from RecoverableZooKeeper
> ----------------------------------------
>
> Key: HBASE-17448
> URL: https://issues.apache.org/jira/browse/HBASE-17448
> Project: HBase
> Issue Type: Improvement
> Components: Zookeeper
> Affects Versions: 1.3.1
> Reporter: Andrew Kyle Purtell
> Assignee: Chinmay Kulkarni
> Priority: Major
> Labels: patch
> Fix For: 1.4.0, 1.4.1, 1.4.2, 2.0.0
>
> Attachments: HBASE-17448-branch-1.patch, HBASE-17448.patch,
> HBASE-17448.patch
>
>
> Consider adding instrumentation to RecoverableZooKeeper that exposes metrics
> on the performance and health of the embedded ZooKeeper client: latency
> histograms for each op type, number of reconnections, number of ops where a
> reconnection was necessary to proceed, number of failed ops due to
> CONNECTIONLOSS, number of failed ops due to SESSIONEXIPRED, number of failed
> ops due to OPERATIONTIMEOUT.
> RecoverableZooKeeper is a class in hbase-client so we can hook up the new
> metrics to both client- and server-side metrics reporters. Probably this
> metrics source should be a process singleton.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
