bsglz commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-649607773
> bq. It also set to true in RSRpcServices.flushRegion, would be called by user. > > ok. The user is asking to flush all regions. If user sets it, could convert it to a list of all families? > > bq. Yeah, i am agree with you, maybe the forceFlushAllStores should be enum, named selectType that include "FORCE_ALL","FORCE_WITH_SPECIFIED","FLUSH_POLICY"? And it is a long story yet, i can do it in follow-on jira, WDYT? > > Why not just remove it? The above seems to be offering too much choice. Navigating all of the options in flushcache will be awkward. > > Thanks. Ok, remove it make sense, let me do it later. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
