[ https://issues.apache.org/jira/browse/HBASE-20819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145696#comment-17145696 ]
Elliot Miller edited comment on HBASE-20819 at 6/25/20, 6:04 PM: ----------------------------------------------------------------- h1. Changed Constants in this Patch This comment documents how I checked which constants are removed by this patch so that we can let users know. h2. Process To get the list of constants: {code:java} echo 'HBaseConstants.constants.sort.each do |c|; puts c; end' | ./bin/hbase shell {code} I repeated this process for commits b556343 (where my branch splits from master) and cf2aa59 (tip of my branch) and saved the resulting lists to two separate files. Then I created a diff: {code:java} diff -u HBaseConstants-b5563432922268c7a16deacbb51bfba89c0a2aba.txt HBaseConstants-cf2aa593e590133b0c76d3723b4074b28b55dcc9.txt{code} I attached the files to this issue for reference. h2. Result These constants were removed from the HBaseConstants module in hbase-shell by this patch: * CACHE_DATA_IN_L1 * COMPARATOR ** Should not have been exposed. This is marked with {@InterfaceAudience.Private} * COMPARATOR_IGNORE_REPLICATION * ENCODE_ON_DISK * FOREVER * IS_MOB_BYTES * IS_ROOT * LENGTH * MOB_COMPACT_PARTITION_POLICY_BYTES * MOB_THRESHOLD_BYTES * REPLICATION_SCOPE_BYTES I will add these to the release notes. was (Author: bitoffdev): h1. Changed Constants in this Patch This comment documents how I checked which constants are removed by this patch so that we can let users know. h2. Process To get the list of constants: {code:java} echo 'HBaseConstants.constants.sort.each do |c|; puts c; end' | ./bin/hbase shell {code} I repeated this process for commits b556343 (where my branch splits from master) and cf2aa59 (tip of my branch) and saved the resulting lists to two separate files. Then I created a diff: {code:java} diff -u HBaseConstants-b5563432922268c7a16deacbb51bfba89c0a2aba.txt HBaseConstants-cf2aa593e590133b0c76d3723b4074b28b55dcc9.txt{code} I attached the files to this issue for reference. h2. Result These constants were removed from the HBaseConstants module in hbase-shell by this patch: * CACHE_DATA_IN_L1 * COMPARATOR * COMPARATOR_IGNORE_REPLICATION * ENCODE_ON_DISK * FOREVER * IS_MOB_BYTES * IS_ROOT * LENGTH * MOB_COMPACT_PARTITION_POLICY_BYTES * MOB_THRESHOLD_BYTES * REPLICATION_SCOPE_BYTES I will add these to the release notes. > Use TableDescriptor to replace HTableDescriptor in hbase-shell module > --------------------------------------------------------------------- > > Key: HBASE-20819 > URL: https://issues.apache.org/jira/browse/HBASE-20819 > Project: HBase > Issue Type: Improvement > Components: shell > Affects Versions: 2.0.0 > Reporter: Xiaolin Ha > Assignee: Elliot Miller > Priority: Minor > Attachments: HBASE-20819.branch-2.001.patch, > HBASE-20819.branch-2.002.patch, > HBaseConstants-b5563432922268c7a16deacbb51bfba89c0a2aba.txt, > HBaseConstants-cf2aa593e590133b0c76d3723b4074b28b55dcc9.txt, > HBaseConstants-diff.txt > > > HTableDescriptor is deprecated as of release 2.0.0, and will be removed in > 3.0.0. This patch replaces all usages of HTableDescriptor and > HColumnDescriptor in the hbase-shell module so that HTableDescriptor can be > removed. > There a few other consequences of this change: > * Ruby methods relating to HTableDescriptor and HColumnDescriptor have been > removed. This is noted in "Release Note" on this issue. > * We no longer import constants from HTableDescriptor and HColumnDescriptor > into the ruby HBaseConstants module. Instead, we import them from > ColumnFamilyDescriptorBuilder and TableDescriptorBuilder. -- This message was sent by Atlassian Jira (v8.3.4#803005)