[ https://issues.apache.org/jira/browse/HBASE-24603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145957#comment-17145957 ]
HBase QA commented on HBASE-24603: ---------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 11s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} branch-1 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 20s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 58s{color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 22s{color} | {color:green} branch-1 passed with JDK v1.8.0_252 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 33s{color} | {color:green} branch-1 passed with JDK v1.7.0_262 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 56s{color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 17s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 17s{color} | {color:green} branch-1 passed with JDK v1.8.0_252 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 31s{color} | {color:green} branch-1 passed with JDK v1.7.0_262 {color} | | {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 2m 52s{color} | {color:blue} Used deprecated FindBugs config; considering switching to SpotBugs. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 37s{color} | {color:green} branch-1 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 18s{color} | {color:green} the patch passed with JDK v1.8.0_252 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 33s{color} | {color:green} the patch passed with JDK v1.7.0_262 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 30s{color} | {color:green} The patch passed checkstyle in hbase-common {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 37s{color} | {color:green} hbase-client: The patch generated 0 new + 77 unchanged - 2 fixed = 77 total (was 79) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 43s{color} | {color:green} The patch passed checkstyle in hbase-server {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 5s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 4m 56s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5 2.9.2. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 9s{color} | {color:green} the patch passed with JDK v1.8.0_252 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 30s{color} | {color:green} the patch passed with JDK v1.7.0_262 {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 39s{color} | {color:red} hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 42s{color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 50s{color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red}167m 24s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 21s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}232m 29s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hbase-client | | | Format-string method String.format(String, Object[]) called with format string "Invalid event of type {} received for path {}. Ignoring" wants 0 arguments but is given 2 in org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.processEvent(WatchedEvent) At ZooKeeperWatcher.java:with format string "Invalid event of type {} received for path {}. Ignoring" wants 0 arguments but is given 2 in org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.processEvent(WatchedEvent) At ZooKeeperWatcher.java:[line 666] | | Failed junit tests | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1976/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1976 | | JIRA Issue | HBASE-24603 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 966ee6e0d634 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1976/out/precommit/personality/provided.sh | | git revision | branch-1 / 54c38c8 | | Default Java | 1.7.0_262 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1976/1/artifact/out/new-findbugs-hbase-client.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1976/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1976/1/testReport/ | | Max. process+thread count | 4624 (vs. ulimit of 10000) | | modules | C: hbase-common hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1976/1/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. > Zookeeper sync() call is async > ------------------------------ > > Key: HBASE-24603 > URL: https://issues.apache.org/jira/browse/HBASE-24603 > Project: HBase > Issue Type: Improvement > Components: master, regionserver > Affects Versions: 3.0.0-alpha-1, 2.3.0, 1.7.0 > Reporter: Bharath Vissapragada > Assignee: Bharath Vissapragada > Priority: Critical > Fix For: 3.0.0-alpha-1, 2.3.1, 1.7.0, 2.4.0 > > > Here is the method that does a sync() of lagging followers with leader in the > quorum. We rely on this to see a consistent snapshot of ZK data from multiple > clients. However the problem is that the underlying sync() call is actually > asynchronous since we are passing a 'null' call back. See the ZK API > [doc|https://zookeeper.apache.org/doc/r3.5.7/apidocs/zookeeper-server/index.html] > for details. The end-result is that sync() doesn't guarantee that it has > happened by the time it returns. > {noformat} > /** > * Forces a synchronization of this ZooKeeper client connection. > * <p> > * Executing this method before running other methods will ensure that the > * subsequent operations are up-to-date and consistent as of the time that > * the sync is complete. > * <p> > * This is used for compareAndSwap type operations where we need to read the > * data of an existing node and delete or transition that node, utilizing > the > * previously read version and data. We want to ensure that the version > read > * is up-to-date from when we begin the operation. > */ > public void sync(String path) throws KeeperException { > this.recoverableZooKeeper.sync(path, null, null); > } > {noformat} > We rely on this heavily (at least in the older branches that do ZK based > region assignment). In branch-1 we saw weird "BadVersionException" exceptions > in RITs because of the inconsistent view of the ZK snapshot. It could > manifest differently in other branches. Either way, this is something we need > to fix. -- This message was sent by Atlassian Jira (v8.3.4#803005)