Reidddddd commented on a change in pull request #1923:
URL: https://github.com/apache/hbase/pull/1923#discussion_r446025854
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
##########
@@ -105,6 +105,16 @@
// We use ring buffer sequence as txid of FSWALEntry and SyncFuture.
private static final Logger LOG = LoggerFactory.getLogger(FSHLog.class);
+ private static final String TOLERABLE_LOW_REPLICATION =
"hbase.regionserver.hlog.tolerable.lowreplication";
+ private static final String LOW_REPLICATION_ROLL_LIMIT =
"hbase.regionserver.hlog.lowreplication.rolllimit";
+ private static final int DEFAULT_LOW_REPLICATION_ROLL_LIMIT = 5;
+ private static final String ROLL_ERRORS_TOLERATED =
"hbase.regionserver.logroll.errors.tolerated";
+ private static final int DEFAULT_ROLL_ERRORS_TOLERATED = 2;
+ private static final String SYNCER_COUNT =
"hbase.regionserver.hlog.syncer.count";
+ private static final int DEFAULT_SYNCER_COUNT = 5;
+ private static final String MAX_BATCH_COUNT =
"hbase.regionserver.hlog.max.batch.count";
Review comment:
After second thought, the new name should use `wal` instead of `hlog`
which was the name in old version.
And from the context in codes, `hbase.regionserver.wal.sync.batch.count`
sounds good to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
