[ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146276#comment-17146276 ]
Duo Zhang commented on HBASE-21782: ----------------------------------- [~ndimiduk] Usually we should keep the deprecated classes for a whole major release, as what we describe in the ref guide. But here I define the IA.Public annotation on LoadIncrementalHFiles as a mistake, especially that it exposes several IA.Private classes, so I used a more aggressive policy to drop the class. IIRC I've gotten consensus from the community. We should add a special note on this in our ref guide too. > LoadIncrementalHFiles should not be IA.Public > --------------------------------------------- > > Key: HBASE-21782 > URL: https://issues.apache.org/jira/browse/HBASE-21782 > Project: HBase > Issue Type: Task > Components: mapreduce > Reporter: Duo Zhang > Assignee: Duo Zhang > Priority: Major > Labels: bulkload > Fix For: 3.0.0-alpha-1, 2.2.0 > > Attachments: HBASE-21782-v1.patch, HBASE-21782.patch > > > It is an implementation class, so some of the methods which are only supposed > to be used by replication sink are also public to users. And it exposes > methods which take Table and Connection as parameter and inside the > implementation we assume that they are HTable and ConnectionImplementation, > which will be a pain when we want to replace the sync client implementation > with async client. > Here I think we should make the implementation class as > IA.LimitPrivate(TOOL), and introduce an interface for bulking hfiles > programmatically. -- This message was sent by Atlassian Jira (v8.3.4#803005)