phrocker commented on a change in pull request #6:
URL: https://github.com/apache/hbase-native-client/pull/6#discussion_r446354713
##########
File path: CMakeLists.txt
##########
@@ -154,6 +160,9 @@ endif (OPENSSL_FOUND)
if (DOWNLOAD_DEPENDENCIES)
+ download_doubleconversion(${CMAKE_CURRENT_SOURCE_DIR}
${CMAKE_CURRENT_BINARY_DIR})
+ download_fizz(${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR})
Review comment:
I pushed a commit but will ping you after I've made some additional
changes regarding this. I'm going to re-run through some tests. thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
