virajjasani commented on a change in pull request #1990:
URL: https://github.com/apache/hbase/pull/1990#discussion_r446620241
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java
##########
@@ -187,19 +190,19 @@ private void checkSplittable(final MasterProcedureEnv env,
boolean splittable = false;
if (node != null) {
try {
- if (bestSplitRow == null || bestSplitRow.length == 0) {
+ GetRegionInfoResponse response;
+ if (!hasBestSplitRow()) {
LOG
.info("splitKey isn't explicitly specified, will try to find a
best split key from RS");
Review comment:
Good to log `node.getRegionInfo().getRegionNameAsString()` as well as
`node.getRegionLocation()` with this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
