[ 
https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149764#comment-17149764
 ] 

Duo Zhang commented on HBASE-11288:
-----------------------------------

{quote}
Thank you for taking a look and your comments. It seems your comments are about 
polish? As mentioned this is a draft patch, does that mean the general 
implementation is ok and I can work on polishing it?
{quote}

I do not understand. While I was talking about the design, and how we could 
make the feature availble step by step, you told me to review your patch, and 
after I reviewed your patch you said this is just a POC so do not focus on 
polishing? Then what do you expect me to do? What I can see is that there are 
full of branch-1 code in the patch and it can not even pass the small UTs.

{quote}
Oh I see you're talking about the PR test result. I ran it locally with -fn so 
I could get all the tests to run. Although I think I ran it without running IT 
tests. I'll run it again after rebase.
{quote}

Of course I'm telling the PR result, I can not see your local result right?

{quote}
I'd really appreciate your response on this question. Having previous 
discussions with you I think we both want split-meta and we both want to do it 
right. So I think we both want the same thing, so maybe we can work a little 
more closely on this?
{quote}

I'm OK with us both implementing the feature. No problem. If you want I will 
open another issue and move all the sub tasks there, and give back this issue 
to you. What I can say is that, I strongly disagree with implementing a general 
ROOT table, we should not tumble at the same place twice. I do not trust the 
read replicas features either, it has been there for years and till now, we 
still have fellas in the community try to stabilize it. That's really not a 
good sign and we should avoid relying on it critically. If you are fine to 
implement based on the master local region approach you can pick up the issues 
you like to implement them. I do not think there will be big difference for the 
split/merge procedures in the two approaches.

Thanks.

> Splittable Meta
> ---------------
>
>                 Key: HBASE-11288
>                 URL: https://issues.apache.org/jira/browse/HBASE-11288
>             Project: HBase
>          Issue Type: Umbrella
>          Components: meta
>            Reporter: Francis Christopher Liu
>            Assignee: Francis Christopher Liu
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to