[ 
https://issues.apache.org/jira/browse/HBASE-24657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150938#comment-17150938
 ] 

Hudson commented on HBASE-24657:
--------------------------------

Results for branch branch-1
        [build #1323 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1323/]: 
(x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1323//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1323//JDK7_Nightly_Build_Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1323//JDK8_Nightly_Build_Report_(Hadoop2)/]




(x) {color:red}-1 source release artifact{color}
-- See build output for details.


> JsonBean representation of metrics at /jmx endpoint now quotes all numbers
> --------------------------------------------------------------------------
>
>                 Key: HBASE-24657
>                 URL: https://issues.apache.org/jira/browse/HBASE-24657
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 1.5.0, 1.6.0, 1.3.6, 1.4.11
>            Reporter: David Manning
>            Assignee: David Manning
>            Priority: Minor
>             Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0, 2.2.6
>
>
> HBASE-20571 had a fix to look for NaN or Infinity in numbers, and to quote 
> those as strings. The order of the `if-else` block is different in branch-1 
> (https://github.com/apache/hbase/commit/2d493556f3c8ae87fb92422b525bf7c9345e6ccd)
>  and branch-2 
> (https://github.com/apache/hbase/commit/39ea1efa885e2f27f41af59228e0a12c4ded08f8)
> HBASE-23015 changed the JsonBean.java code in a meaningful way, and the order 
> of the changes were consistent between branch-1 
> ([https://github.com/apache/hbase/commit/f77c14d18150f55ee892f8d24a5ee231c1ae7e20#diff-87e9e2722b9210eebfd8c820c5d72a46L319-L324])
>  and branch-2 
> ([https://github.com/apache/hbase/commit/761aef6d9d0b8a455842de4d5eac7d9486f00633#diff-2c8f5dd222141c69112c5c5b5f70cf55R319-R324])
>  Unfortunately, they need to be reversed since the order is different between 
> branch-1 and branch-2.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to