bsglz commented on a change in pull request #2011: URL: https://github.com/apache/hbase/pull/2011#discussion_r450842948
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java ########## @@ -68,22 +76,14 @@ protected void configureForRegion(HRegion region) { @Override protected boolean shouldSplit() { - boolean foundABigStore = false; - + // If any of the stores is unable to split (eg they contain reference files) + // then don't split for (HStore store : region.getStores()) { - // If any of the stores are unable to split (eg they contain reference files) - // then don't split - if ((!store.canSplit())) { + if (!store.canSplit()) { Review comment: Although IncreasingToUpperBoundRegionSplitPolicy override the shouldSplit, but does not override isExceedSize. IMO, even if there is only ConstantSizeRegionSplitPolicy, the ref check should be precondition of size check, since if any store has ref file, all stores are no need to check. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org