saintstack commented on a change in pull request #2037:
URL: https://github.com/apache/hbase/pull/2037#discussion_r452354554
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java
##########
@@ -128,14 +124,8 @@
public class CanaryTool implements Tool, Canary {
public static final String HBASE_CANARY_INFO_PORT = "hbase.canary.info.port";
- public static final int DEFAULT_CANARY_INFOPORT = 16050;
-
- public static final String HBASE_CANARY_INFO_BINDADDRESS =
"hbase.canary.info.bindAddress";
Review comment:
Both defines are used in one place only. These defines seem superfluous
when one-use only. What you thinking?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
