sanjeetnishad95 commented on a change in pull request #2047:
URL: https://github.com/apache/hbase/pull/2047#discussion_r453718395
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##########
@@ -3000,7 +3001,12 @@ private void getProcedureResult(long procId,
CompletableFuture<Void> future, int
// If any region compaction state is MAJOR_AND_MINOR
// the table compaction state is MAJOR_AND_MINOR, too.
if (err2 != null) {
-
future.completeExceptionally(unwrapCompletionException(err2));
+ // api can throw NSRE when the region is not online(split,
splitting, merge,
+ // merging, etc). Those regions will not be filtered above
so it's better to skip
+ // regions which throw NSRE.
+ if (!(err2.getCause() instanceof NotServingRegionException))
{
Review comment:
yes, this approach makes more sense. I think it's better to add a new
flag for tracking offline regions in RegionInfo as the old `isOffline()` serves
other purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
