[ 
https://issues.apache.org/jira/browse/HBASE-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265000#comment-13265000
 ] 

stack commented on HBASE-5889:
------------------------------

bq. I'm just not sure this is actually the best bang for the buck, and might 
make layering less clean.

Because the HRegion APIs would all take pbs rather than the Get/Put/Delete, 
etc.?  And doing this conversion would be a bunch of work that would be better 
spent doing other stuff?

Serverside, going from pb into Get/Delete/Put just to get the data into and out 
of regions seems gratuitous and crud we should purge.

Your profiling though would seem to make this a minor issue, one I would have 
thought prviously critical to address.
                
> Remove HRegionInterface
> -----------------------
>
>                 Key: HBASE-5889
>                 URL: https://issues.apache.org/jira/browse/HBASE-5889
>             Project: HBase
>          Issue Type: Improvement
>          Components: client, ipc, regionserver
>    Affects Versions: 0.96.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>
> As a step to move internals to PB, so as to avoid the conversion for 
> performance reason, we should remove the HRegionInterface. 
> Therefore region server only supports ClientProtocol and AdminProtocol.  
> Later on, HRegion can work with PB messages directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to