wchevreuil commented on a change in pull request #2052: URL: https://github.com/apache/hbase/pull/2052#discussion_r454402502
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/LogEventHandler.java ########## @@ -0,0 +1,101 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hbase.namequeues; + +import com.lmax.disruptor.EventHandler; +import com.lmax.disruptor.RingBuffer; + +import java.util.HashMap; +import java.util.Map; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.namequeues.request.NamedQueueGetRequest; +import org.apache.hadoop.hbase.namequeues.response.NamedQueueGetResponse; +import org.apache.yetus.audience.InterfaceAudience; + +/** + * Event Handler run by disruptor ringbuffer consumer. + * Although this is generic implementation for namedQueue, it can have individual queue specific + * logic. + */ +@InterfaceAudience.Private +class LogEventHandler implements EventHandler<RingBufferEnvelope> { + + // Map that binds namedQueues to corresponding queue service implementation. + // If NamedQueue of specific type is enabled, corresponding service will be used to + // insert and retrieve records. + // Individual queue sizes should be determined based on their individual configs within + // each service. + private final Map<NamedQueuePayload.NamedQueueEvent, NamedQueueService> namedQueueServices = + new HashMap<>(); + + LogEventHandler(final Configuration conf) { + // add all service mappings here + namedQueueServices Review comment: How about define a String collection property for all implementations of NamedQueueService? So that this handler can load those dynamically, without requiring code changes once new implementations are added. ########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/SlowLogPersistentService.java ########## @@ -0,0 +1,98 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hbase.namequeues; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog; +import org.apache.hadoop.hbase.slowlog.SlowLogTableAccessor; +import org.apache.hbase.thirdparty.com.google.common.collect.EvictingQueue; +import org.apache.hbase.thirdparty.com.google.common.collect.Queues; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import java.util.ArrayList; +import java.util.List; +import java.util.Queue; +import java.util.concurrent.locks.ReentrantLock; + +/** + * Persistent service provider for Slow/LargeLog events + */ +@InterfaceAudience.Private +public class SlowLogPersistentService { Review comment: Ah, got confused by the SlowLog and Service terms in the name, now saw this is only used by SlowLogQueueService implementation. Yeah, I guess no need to define interface for now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
