bsglz commented on a change in pull request #2044: URL: https://github.com/apache/hbase/pull/2044#discussion_r456751970
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java ########## @@ -827,26 +828,34 @@ protected double scale(double min, double max, double value) { */ static class MoveCostFunction extends CostFunction { private static final String MOVE_COST_KEY = "hbase.master.balancer.stochastic.moveCost"; + private static final String MOVE_COST_OFFPEAK_KEY = "hbase.master.balancer.stochastic.moveCost.offpeak"; private static final String MAX_MOVES_PERCENT_KEY = "hbase.master.balancer.stochastic.maxMovePercent"; - private static final float DEFAULT_MOVE_COST = 7; + @VisibleForTesting + protected static final float DEFAULT_MOVE_COST = 7; + protected static final float DEFAULT_MOVE_COST_OFFPEAK = 3; Review comment: IMO, the main different of two ways is whether we need to update test code or not when we change the default value. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org