ramkrish86 commented on a change in pull request #2093:
URL: https://github.com/apache/hbase/pull/2093#discussion_r457061034
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
##########
@@ -584,8 +584,12 @@ public void run() {
Throwable lastException = null;
try {
TraceUtil.addTimelineAnnotation("syncing writer");
+ long unSyncedFlushSeq = highestUnsyncedTxid;
writer.sync(takeSyncFuture.isForceSync());
TraceUtil.addTimelineAnnotation("writer synced");
+ if (unSyncedFlushSeq > currentSequence) {
+ currentSequence = unSyncedFlushSeq;
Review comment:
I think this makes sense. @cuibo01 is this change running in production
? By the time we actually perform the sync if an append has happened it should
have got synced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
