joshelser commented on a change in pull request #2114:
URL: https://github.com/apache/hbase/pull/2114#discussion_r458341484



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
##########
@@ -173,6 +175,8 @@ int scan() throws IOException {
       this.lastReport = scanForReport();
       if (!this.lastReport.isEmpty()) {
         LOG.warn(this.lastReport.toString());
+        // expires unknown servers
+        repairUnknownServers();

Review comment:
       I guess not an issue for master (which doesn't have the separate 
namespace table), but elsewhere do we still have 
`hbase.master.namespace.init.timeout` setting an upper-bound on how long we 
wait for hbase:namespace to get assigned? Thinking that, waiting for 
CatalogJanitor to run, will be a pretty "slow" solution (up to 5min wait), and 
we may have a master crash if the ns init timeout is 5 mins as well as the 
catalog janitor's interval.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to