[
https://issues.apache.org/jira/browse/HBASE-24750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162531#comment-17162531
]
Viraj Jasani commented on HBASE-24750:
--------------------------------------
Umm yeah there is no harm as such, only thing is we have guava dependency just
for a builder class and no other advantages. That's why I thought why not use
our internal one, but I don't have strong preference. If the consensus is to
use guava, it's quite fine, but yes the main point is to retire one of them at
least :)
> All executor service should start using our internal ThreadFactory
> ------------------------------------------------------------------
>
> Key: HBASE-24750
> URL: https://issues.apache.org/jira/browse/HBASE-24750
> Project: HBase
> Issue Type: Improvement
> Reporter: Viraj Jasani
> Priority: Major
>
> Currently, we have majority Executor services using guava's
> ThreadFactoryBuilder while creating fixed size thread pool. There are some
> executors using our internal hbase-common's Threads class which provides util
> methods for creating thread factory.
> Although there is no perf impact, we should let all Executors start using our
> internal library for using ThreadFactory rather than having external guava
> dependency (which is nothing more than a builder class). We might have to add
> a couple more arguments to support full fledged ThreadFactory, but let's do
> it and stop using guava's builder class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
