wchevreuil commented on a change in pull request #2077:
URL: https://github.com/apache/hbase/pull/2077#discussion_r458668799
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java
##########
@@ -87,8 +108,24 @@ public void stop() {
}
@Override
- protected void doStart() {
+ protected synchronized void doStart() {
try {
+ try (Admin admin = getPeerConnection().getAdmin()) {
+ String version = admin.getClusterMetrics().getHBaseVersion();
+ LOG.info("Peer cluster version is {} for peer {}", version,
ctx.getPeerId());
+ if (Integer.parseInt(version.split("\\.")[0]) >= 3) {
Review comment:
> ReplicationSinkManager.chooseSinks will be called to re-fetch the
sinks when HBaseInterClusterReplicationEndpoint.replicate catches
ConnectException or UnknownHostException, It's same as before.
Yeah, haven't looked at the outer catch from replicate. Another thought them
is if we really need the new chore? I wonder how effective it would really be
to avoid trying stale sinks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
