virajjasani commented on a change in pull request #2118:
URL: https://github.com/apache/hbase/pull/2118#discussion_r458920644
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSinkManager.java
##########
@@ -150,9 +151,14 @@ public synchronized void reportSinkSuccess(SinkPeer
sinkPeer) {
*/
public synchronized void chooseSinks() {
List<ServerName> slaveAddresses = endpoint.getRegionServers();
Review comment:
Further down in `setRegionServers(fetchSlavesAddresses(this.getZkw()))`,
`fetchSlavesAddresses()`is not returning null, but empty list. So maybe we can
safely log warning for `if(slaveAddresses.size()==0)` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
