[ https://issues.apache.org/jira/browse/HBASE-24743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164641#comment-17164641 ]
Hudson commented on HBASE-24743: -------------------------------- Results for branch branch-2 [build #2758 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2758/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2758/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2758/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2758/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2758/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Reject to add a peer which replicate to itself earlier > ------------------------------------------------------ > > Key: HBASE-24743 > URL: https://issues.apache.org/jira/browse/HBASE-24743 > Project: HBase > Issue Type: Improvement > Reporter: Guanghao Zhang > Assignee: Guanghao Zhang > Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > > Now there are one check in ReplicationSource#initialize method > {code:java} > // In rare case, zookeeper setting may be messed up. That leads to the > incorrect > // peerClusterId value, which is the same as the source clusterId > if (clusterId.equals(peerClusterId) && > !replicationEndpoint.canReplicateToSameCluster()) { > this.terminate("ClusterId " + clusterId + " is replicating to itself: > peerClusterId " > + peerClusterId + " which is not allowed by ReplicationEndpoint:" > + replicationEndpoint.getClass().getName(), null, false); > this.manager.removeSource(this); > return; > } > {code} > This check should move to AddPeerProcedure's precheck. -- This message was sent by Atlassian Jira (v8.3.4#803005)