[GitHub] [hbase] utf7 commented on a change in pull request #2167: HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method

[GitBox]

utf7 commented on a change in pull request #2167:
URL: https://github.com/apache/hbase/pull/2167#discussion_r462120907



##########
File path: 
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java
##########
@@ -248,7 +248,6 @@ public void write(ImmutableBytesWritable row, V cell) 
throws IOException {
           tableNameBytes = Bytes.toBytes(writeTableNames);
         }
         String tableName = Bytes.toString(tableNameBytes);
-        Path tableRelPath = getTableRelativePath(tableNameBytes);

Review comment:
       
   tableName split 3 times int  getTableRelativePath method has fixed in this 
PR 
   
   i will do some other fixes  in next commit , the code there is a little mess

##########
File path: 
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java
##########
@@ -222,6 +222,7 @@ public RegionLocator getRegionLocator() {
       private final Map<byte[], WriterLength> writers = new 
TreeMap<>(Bytes.BYTES_COMPARATOR);
       private final Map<byte[], byte[]> previousRows = new 
TreeMap<>(Bytes.BYTES_COMPARATOR);
       private final long now = EnvironmentEdgeManager.currentTime();
+      private byte[] tableNameBytes =  Bytes.toBytes(writeTableNames);;

Review comment:
       ok,thanks for ponit it 

##########
File path: 
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java
##########
@@ -222,6 +222,7 @@ public RegionLocator getRegionLocator() {
       private final Map<byte[], WriterLength> writers = new 
TreeMap<>(Bytes.BYTES_COMPARATOR);
       private final Map<byte[], byte[]> previousRows = new 
TreeMap<>(Bytes.BYTES_COMPARATOR);
       private final long now = EnvironmentEdgeManager.currentTime();
+      private byte[] tableNameBytes =  Bytes.toBytes(writeTableNames);;

Review comment:
       has finished 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org