Apache9 commented on pull request #29: URL: https://github.com/apache/hbase-thirdparty/pull/29#issuecomment-669958179
Finally I could get all the UTs under hbase-http to pass with the shaded jetty and jersey. There are still two problems: 1. Shaded plugin can not deal with some string literals. https://github.com/eclipse/jetty.project/blob/450ba27947e13e66baa8cd1ce7e85a4461cacc1d/jetty-webapp/src/main/java/org/eclipse/jetty/webapp/WebAppContext.java#L137 The elements of WebAppContext.__dftServerClasses have '-' at the beginning and the shade plugin will not relocate them and cause trouble(although when shading source they are relocated...). I do not know how to replace string literals in a class file, so the solution is to write a method in the hbase code base to do the replacement... 2. The behavior of HttpServletResponse.sendError has been changed. In the past jetty will append the error message in the status line but in jetty 9.4 it will not, and cause the TestProxyUserSpnegoHttpServer.testProxyDisallowedForUnprivileged to fail. Seems introduced by this commit https://github.com/eclipse/jetty.project/commit/bde86467f4e5df595773ab11ed5e80c615b741f3#diff-03fcd9b9e322e2bb4fdb46f2bbea27b3 Not sure if it is intenional or not... But anyway this could also be solved by changing the test, not a big deal. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
