saintstack commented on a change in pull request #2018:
URL: https://github.com/apache/hbase/pull/2018#discussion_r466700781
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -8405,12 +8405,7 @@ private static long getLongValue(final Cell cell) throws
DoNotRetryIOException {
return cells;
}
- public static final long FIXED_OVERHEAD = ClassSize.align(
- ClassSize.OBJECT +
- 56 * ClassSize.REFERENCE +
- 3 * Bytes.SIZEOF_INT +
- 14 * Bytes.SIZEOF_LONG +
- 3 * Bytes.SIZEOF_BOOLEAN);
+ public static final long FIXED_OVERHEAD =
ClassSize.estimateBase(HRegion.class, false);
Review comment:
I thought it critical it did deep size? Do you get the same numbers
roughly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
