virajjasani commented on a change in pull request #2215: URL: https://github.com/apache/hbase/pull/2215#discussion_r468525092
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/NormalizeTableFilterParams.java ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.client; + +import java.util.List; +import org.apache.hadoop.hbase.TableName; +import org.apache.yetus.audience.InterfaceAudience; +import org.apache.yetus.audience.InterfaceStability; + +/** + * A collection of criteria used for table selection. + */ [email protected] [email protected] +public class NormalizeTableFilterParams { + private final List<TableName> tableNames; + private final String regex; + private final String namespace; + + public NormalizeTableFilterParams( Review comment: Usually don't we want to provide only one way of creating objects? Exposing both doesn't harm anyway but I have hardly seen any class exposing both: constructor and builder class. Or do we follow this in HBase somewhere? ########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ########## @@ -2293,6 +2293,13 @@ public static TableName toTableName(HBaseProtos.TableName tableNamePB) { .setQualifier(UnsafeByteOperations.unsafeWrap(tableName.getQualifier())).build(); } + public static List<HBaseProtos.TableName> toProtoTableNameList(List<TableName> tableNameList) { + if (tableNameList == null) { + return new ArrayList<>(); Review comment: For the purpose of this PR, if we return non-modifiable collection, `getTableDescriptors` in HMaster will interpret it as expected: `if (tableNameList == null || tableNameList.isEmpty()) {`, however since this is generic method and we are following the same approach for majority of util methods on this class, we can keep it same way. > Even if not, probably these ArrayLists should be replaced with LinkedList. You meant as separate task right? +1 ########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ########## @@ -1908,14 +1907,18 @@ public RegionNormalizer getRegionNormalizer() { return this.normalizer; } + public boolean normalizeRegions() throws IOException { + return normalizeRegions(new NormalizeTableFilterParams.Builder().build()); Review comment: Yeah you are right, GC'ing sounds better. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
