[
https://issues.apache.org/jira/browse/HBASE-24874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176727#comment-17176727
]
Elliot Miller commented on HBASE-24874:
---------------------------------------
[~zhangduo], we do have unit tests for both these cases in TestAdminShell.java.
These shell unit tests are actually the reason that one of my open PRs
([https://github.com/apache/hbase/pull/2232]) is failing CI testing.
I just took a look at the nightly build for both JDK 8 and 11. hbase-shell is
passing for both of them. (/)
I think the problem is that *TestAdminShell is not always run in CI*. It was
definitely run for my recently opened PR. However, *TestAdminShell now appears
in the list of flaky excludes* for the master branch, so it is not being run on
nightly builds. This may have other effects, but I'm not familiar enough with
our CI to comment further at the moment. See
[https://ci-hadoop.apache.org/job/HBase/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/dashboard.html]
I'll have a chance to look into this further tomorrow.
> hbase-shell should not use ModifiableTableDescriptor directly
> -------------------------------------------------------------
>
> Key: HBASE-24874
> URL: https://issues.apache.org/jira/browse/HBASE-24874
> Project: HBase
> Issue Type: Bug
> Components: shell
> Affects Versions: 3.0.0-alpha-1
> Reporter: Elliot Miller
> Assignee: Elliot Miller
> Priority: Major
>
> HBASE-20819 prepared us for HBase 3.x by removing usages of the deprecated
> HTableDescriptor and HColumnDescriptor classes from the shell. However, it
> did use two methods from the ModifiableTableDescriptor, which was only public
> for compatibility/migration and was marked with
> {{@InterfaceAudience.Private}}. When {{ModifiableTableDescriptor}} was made
> private last week by HBASE-24507 it broke two hbase-shell commands
> (*describe* and *alter* when used to set a coprocessor) that were using
> methods from {{ModifiableTableDescriptor}} (these methods are not present on
> the general {{TableDescriptor}} interface).
> This story will remove the two references in hbase-shell to methods on the
> now-private {{ModifiableTableDescriptor}} class and will find appropriate
> replacements for the calls.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
