[
https://issues.apache.org/jira/browse/HBASE-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267053#comment-13267053
]
jirapos...@reviews.apache.org commented on HBASE-5444:
------------------------------------------------------
bq. On 2012-05-02 23:43:07, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/master/HMaster.java, line 79
bq. > <https://reviews.apache.org/r/4463/diff/5/?file=106063#file106063line79>
bq. >
bq. > We can move the ipc protocol stuff to top level later... I was
thinking that these classes shared by master and regionservers could be at
o.a.h.h... but can do that later if it makes sense. Lets get this pb stuff in
first.
bq. >
bq. >
Sounds good.
bq. On 2012-05-02 23:43:07, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/master/HMaster.java, line 80
bq. > <https://reviews.apache.org/r/4463/diff/5/?file=106063#file106063line80>
bq. >
bq. > We need this?
I use it to convert the PB serverName that is passed into
HMaster.regionServerReport into a ServerName that the ServerManager
understands. Instead, we could have a ServerName static function that takes a
PB ServerName and returns a ServerName. We already have a bunch of these
parse* functions already, e.g.
public static ServerName parseVersionedServerName(final byte [] versionedBytes)
bq. On 2012-05-02 23:43:07, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/ClusterStatus.java, line 36
bq. > <https://reviews.apache.org/r/4463/diff/5/?file=106055#file106055line36>
bq. >
bq. > We need this import? Its for cp. Thats ok I'd say.... One day we
can hide that too..
I think we can get rid of this once I pb-ify the HMasterInterface. I'll put it
on my list to check out. There's probably a few such cases.
- Gregory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4463/#review7492
-----------------------------------------------------------
On 2012-05-02 23:19:20, Gregory Chanan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4463/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-02 23:19:20)
bq.
bq.
bq. Review request for hbase and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Adds PB-based calls replacing HMasterRegionInterface.
bq.
bq. There are some temporary hacks, e.g. converting PB-based ServerLoad to
existing HServerLoad so I didn't need to convert ClusterStatus (which brings in
a lot of other changes). That will be cleaned up in HBASE-5445.
bq.
bq.
bq. This addresses bug HBASE-5444.
bq. https://issues.apache.org/jira/browse/HBASE-5444
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
69434f7
bq.
src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
3c7c091
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 5d7f07b
bq. src/main/java/org/apache/hadoop/hbase/ServerLoad.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 0db2760
bq. src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 973c7cb
bq. src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java
fd97830
bq. src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java bb6ab3b
bq.
src/main/java/org/apache/hadoop/hbase/ipc/RegionServerStatusProtocol.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
f56127d
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 81e9023
bq. src/main/java/org/apache/hadoop/hbase/master/MXBean.java 7f44dc2
bq. src/main/java/org/apache/hadoop/hbase/master/MXBeanImpl.java 45b8fe7
bq. src/main/java/org/apache/hadoop/hbase/master/MasterDumpServlet.java
be63838
bq. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 80271b1
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java 994cb76
bq.
src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
efcf74d
bq.
src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionServerStatusProtos.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
ebffad6
bq. src/main/protobuf/RegionServerStatus.proto PRE-CREATION
bq. src/main/protobuf/hbase.proto 12e6053
bq. src/main/resources/hbase-webapps/master/table.jsp 3ef1190
bq. src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 72554cb
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
d039be3
bq. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
36046f8
bq. src/test/java/org/apache/hadoop/hbase/master/TestMXBean.java bd5fa90
bq. src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java
f8029ba
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
e99d251
bq.
bq. Diff: https://reviews.apache.org/r/4463/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran jenkins job, all unit tests passed.
bq.
bq.
bq. Thanks,
bq.
bq. Gregory
bq.
bq.
> Add PB-based calls to HMasterRegionInterface
> --------------------------------------------
>
> Key: HBASE-5444
> URL: https://issues.apache.org/jira/browse/HBASE-5444
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Todd Lipcon
> Assignee: Gregory Chanan
> Attachments: HBASE-5444-v6-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
