[ https://issues.apache.org/jira/browse/HBASE-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267127#comment-13267127 ]
Zhihong Yu commented on HBASE-5914: ----------------------------------- bq. I think we needn't whether servers is empty, if it is empty, bulkPlan is null Is that so ? {code} + servers.removeAll(failedPlans.keySet()); {code} If servers become empty (failedPlans is not empty), we don't need to execute the following loop: {code} + for (Map.Entry<ServerName, List<HRegionInfo>> e : failedPlans.entrySet()) { {code} Coming out of the top-most quickAssign() call, how do we know that regions have been assigned ? > Bulk assign regions in the process of ServerShutdownHandler > ----------------------------------------------------------- > > Key: HBASE-5914 > URL: https://issues.apache.org/jira/browse/HBASE-5914 > Project: HBase > Issue Type: Improvement > Reporter: chunhui shen > Assignee: chunhui shen > Fix For: 0.96.0 > > Attachments: HBASE-5914.patch, HBASE-5914v2.patch > > > In the process of ServerShutdownHandler, we currently assign regions singly. > In the large cluster, one regionserver always carried many regions, this > action is quite slow. > What about using bulk assign regions like cluster start up. > In current logic, if we failed assigning many regions to one destination > server, we will wait unitl timeout, > however in the process of ServerShutdownHandler, we should retry it to > another server. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira