nyl3532016 commented on a change in pull request #2292:
URL: https://github.com/apache/hbase/pull/2292#discussion_r475308663
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -1064,19 +1065,34 @@ private boolean isTableInGroup(TableName tableName,
String groupName,
return rit;
}
- private Map<TableName, Map<ServerName, List<RegionInfo>>>
getRSGroupAssignmentsByTable(
- String groupName) throws IOException {
+ /**
+ * This is an EXPENSIVE clone. Cloning though is the safest thing to do.
+ * Can't let out original since it can change and at least the load balancer
+ * wants to iterate this exported list.
Review comment:
I have added this comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
