[GitHub] [hbase] infraio commented on a change in pull request #2354: HBASE-24986 Move ReplicationBarrier related methods to a separated class

[GitBox]

infraio commented on a change in pull request #2354:
URL: https://github.com/apache/hbase/pull/2354#discussion_r484240582



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/GCMergedRegionsProcedure.java
##########
@@ -88,7 +87,7 @@ protected Flow executeFromState(MasterProcedureEnv env, 
GCMergedRegionsState sta
         setNextState(GCMergedRegionsState.GC_REGION_EDIT_METADATA);
         break;
       case GC_REGION_EDIT_METADATA:
-        
MetaTableAccessor.deleteMergeQualifiers(env.getMasterServices().getConnection(),
 mergedChild);
+        
env.getAssignmentManager().getRegionStateStore().deleteMergeQualifiers(mergedChild);

Review comment:
       Is it possible NPE in this long call chain?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org