ndimiduk commented on a change in pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#discussion_r486465824



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, 
Action action) {
     }
   }
 
+  private void addCostFunction(CostFunction costFunction) {
+    if (costFunction.getMultiplier() <= 0) {
+      LOG.info("exclude cost function {}", 
costFunction.getClass().getSimpleName());

Review comment:
       How about inverting the logic, only log the functions loaded, rather 
than those skipped, and please make it a `DEBUG` level.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to