shahrs87 commented on a change in pull request #2322:
URL: https://github.com/apache/hbase/pull/2322#discussion_r487273056



##########
File path: 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +974,19 @@ private RegionLocations locateRegionInMeta(TableName 
tableName, byte[] row, bool
     }
   }
 
+  void takeUserRegionLock() throws IOException {
+    try {
+      long waitTime = connectionConfig.getScannerTimeoutPeriod();

Review comment:
       > Operation timeout is not the best choice too but better
   
   @infraio  In scan operation, there are 2 operations. One is to wait for lock 
and other is to wait for rpc to complete. On top of that we have retries. The 
problem we are trying to solve here is what is the timeout to use for lock. If 
we wait for operation timeout period and if it can't get the lock after the 
timeout, it will not have any time remaining for next attempts. So I am 
confused when you suggest to use operation timeout, are you suggesting to wait 
for operation timeout period while trying to get lock ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to