ndimiduk commented on a change in pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#discussion_r487186272
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster,
Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}",
costFunction.getClass().getSimpleName());
Review comment:
@clarax Oh, right. Since there's already a summary log at info that
lists out all the loaded functions, I'd say omit the debug logging entirely.
You good with that plan @virajjasani ?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster,
Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}",
costFunction.getClass().getSimpleName());
Review comment:
@clarax Oh, right. Since there's already a summary log at info that
lists out all the loaded functions, I'd say omit the debug logging entirely.
You good with that plan @virajjasani ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
