[ https://issues.apache.org/jira/browse/HBASE-5494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268118#comment-13268118 ]
Phabricator commented on HBASE-5494: ------------------------------------ avf has commented on the revision "[jira] [HBASE-5494] [89-fb] Table-level locks for schema changing operations.". Thanks @Kannan, I'll implement these suggestions right now. I'm also going to make lockTable() and unlockTable() package-local methods for now, to encourage indicate that they are (as @stack puts it) internal to the schema changing operations, rather than general purpose. I'm also trying out @mbautin's suggestion of 1) checking that table doesn't already exist before acquiring the lock in createTable(), 2) then checking that the table doesn't exist again after acquiring the lock. Will put up an updated diff. REVISION DETAIL https://reviews.facebook.net/D2997 > Introduce a zk hosted table-wide read/write lock so only one table operation > at a time > -------------------------------------------------------------------------------------- > > Key: HBASE-5494 > URL: https://issues.apache.org/jira/browse/HBASE-5494 > Project: HBase > Issue Type: Improvement > Reporter: stack > Attachments: D2997.3.patch, D2997.4.patch > > > I saw this facility over in the accumulo code base. > Currently we just try to sort out the mess when splits come in during an > online schema edit; somehow we figure we can figure all possible region > transition combinations and make the right call. > We could try and narrow the number of combinations by taking out a zk table > lock when doing table operations. > For example, on split or merge, we could take a read-only lock meaning the > table can't be disabled while these are running. > We could then take a write only lock if we want to ensure the table doesn't > change while disabling or enabling process is happening. > Shouldn't be too hard to add. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira