[ 
https://issues.apache.org/jira/browse/HBASE-25021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196870#comment-17196870
 ] 

Duo Zhang commented on HBASE-25021:
-----------------------------------

This is the related code

{code}
  public static void addHBaseDependencyJars(Configuration conf) throws 
IOException {
    addDependencyJarsForClasses(conf,
      // explicitly pull a class from each module
      org.apache.hadoop.hbase.HConstants.class,                      // 
hbase-common
      org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos.class, // 
hbase-protocol-shaded
      org.apache.hadoop.hbase.client.Put.class,                      // 
hbase-client
      org.apache.hadoop.hbase.ipc.RpcServer.class,                   // 
hbase-server
      org.apache.hadoop.hbase.CompatibilityFactory.class,            // 
hbase-hadoop-compat
      org.apache.hadoop.hbase.mapreduce.JobUtil.class,               // 
hbase-hadoop2-compat
      org.apache.hadoop.hbase.mapreduce.TableMapper.class,           // 
hbase-mapreduce
      org.apache.hadoop.hbase.metrics.impl.FastLongHistogram.class,  // 
hbase-metrics
      org.apache.hadoop.hbase.metrics.Snapshot.class,                // 
hbase-metrics-api
      org.apache.hadoop.hbase.replication.ReplicationUtils.class,    // 
hbase-replication
      org.apache.hadoop.hbase.http.HttpServer.class,                 // 
hbase-http
      org.apache.hadoop.hbase.procedure2.Procedure.class,            // 
hbase-procedure
      org.apache.hadoop.hbase.zookeeper.ZKWatcher.class,             // 
hbase-zookeeper
      org.apache.hbase.thirdparty.com.google.common.collect.Lists.class, // 
hb-shaded-miscellaneous
      org.apache.hbase.thirdparty.com.google.gson.GsonBuilder.class, // 
hbase-shaded-gson
      
org.apache.hbase.thirdparty.com.google.protobuf.UnsafeByteOperations.class, // 
hb-sh-protobuf
      org.apache.hbase.thirdparty.io.netty.channel.Channel.class,    // 
hbase-shaded-netty
      org.apache.zookeeper.ZooKeeper.class,                          // 
zookeeper
      com.google.protobuf.Message.class,                             // protobuf
      org.apache.htrace.core.Tracer.class,                           // htrace
      com.codahale.metrics.MetricRegistry.class,                     // 
metrics-core
      org.apache.commons.lang3.ArrayUtils.class);                    // 
commons-lang
  }
{code}

I guess the problem is that, after upgrading the maven shade plugin(IIRC I 
upgrade it for addressing the problems when shading jetty), it also relocates 
the com.google.protobuf.Message.class...

I think for master, we could just remove this line of code, since on master, we 
do not have hbase-protocol any more which means we do not depend on non-shaded 
protobuf any more. It is hadoop's duty to add the protobuf dependency for its 
own.

> Nightly job should skip hadoop-2 integration test for master
> ------------------------------------------------------------
>
>                 Key: HBASE-25021
>                 URL: https://issues.apache.org/jira/browse/HBASE-25021
>             Project: HBase
>          Issue Type: Bug
>          Components: build, scripts
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>
> Since master does not support hadoop 2.x any more.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to