ddupg commented on a change in pull request #2397: URL: https://github.com/apache/hbase/pull/2397#discussion_r491784226
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ########## @@ -3321,4 +3325,33 @@ public UpdateRSGroupConfigResponse updateRSGroupConfig(RpcController controller, } return builder.build(); } + + @Override + public RegionServerReportResponse replicationServerReport(RpcController controller, + RegionServerReportRequest request) throws ServiceException { + try { + master.checkServiceStarted(); + int versionNumber = 0; + String version = "0.0.0"; + VersionInfo versionInfo = VersionInfoUtil.getCurrentClientVersionInfo(); + if (versionInfo != null) { + version = versionInfo.getVersion(); Review comment: `versionNumber` is packed by number part of `version`, can't display string suffixes like "-SNAPSHOT". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org